[ Fix ] 약속 리스트 페이지 에러 처리 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijieun
approved these changes
Oct 16, 2024
| const { prevTap } = location.state || {}; | ||
|
|
||
| const [tap, setTap] = useState('pending'); |
There was a problem hiding this comment.
P4) 개인적인 생각으로 tap 이라는 변수명이 의도가 직관적으로 와닿지 않아서 appointmentStatus 등의 의미가 드러나는 이름을 사용하면 좋을 것 같습니다!
j-nary
approved these changes
Oct 18, 2024
Comment on lines
328
to
344
| {viewType === 'DECLINE' ? ( | ||
| <AutoCloseModal text="선약이 거절되었어요" showModal={isModalOpen} handleShowModal={handleModalOpen} path="/promiseList"> | ||
| <AutoCloseModal | ||
| text="선약이 거절되었어요" | ||
| showModal={isModalOpen} | ||
| handleShowModal={handleModalOpen} | ||
| path="/promiseList"> | ||
| <ModalRejectImg /> | ||
| </AutoCloseModal> | ||
| ) : ( | ||
| <AutoCloseModal text="선약이 수락되었어요" showModal={isModalOpen} handleShowModal={handleModalOpen} path="/promiseList"> | ||
| <AutoCloseModal | ||
| text="선약이 수락되었어요" | ||
| showModal={isModalOpen} | ||
| handleShowModal={handleModalOpen} | ||
| path="/promiseList"> | ||
| <ModalAcceptImg /> | ||
| </AutoCloseModal> | ||
| )} |
There was a problem hiding this comment.
viewType에 따라 text랑 Img만 조건부 넣어주면 더 깔끔해질 것 같아요!
<AutoCloseModal
text={viewType === 'DECLINE' ? "거절" : "수락"}
...
/>
{viewType === 'DECLINE' ? <RejectImg/> : <AcceptImg/>}| @@ -74,11 +74,11 @@ export const usePatchSeniorAccept = (onSuccessCallback?: () => void) => { | |||
| }, | |||
| }); | |||
|
|
|||
| return { mutate, data }; | |||
| return { mutate, data, isPending, isError }; | |||
| }; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#️⃣ Related Issue
Closes #283
✅ Done Task
☀️ New-insight
💎 PR Point
약속디테일페이지로 전달되는 값들이 undefined로 잡힐 경우 다시약속 리스트로 라우팅 시켜줬습니다 (location.state의 값들이 전부 약속리스트 페이지에서부터 전달되기 때문에)이렇게 두 개의 api를 쏴야하는데, 구글밋 링크 생성 api가 생각보다 오래걸려서 (1~2초 정도) 사용자가 이게 요청이 간 건지 모를 것 같더라구요
isLoading 받아와서 로딩스피너 추가해주었습니다.
📸 Screenshot
약속 수락 로딩스피너 추가한 부분
2024-10-14.11.44.14.mov