[#14097] Create Submission Reminders page by javieryeow · Pull Request #14370 · TEAMMATES/teammates

javieryeow · 2026-06-28T09:20:57Z

Fixes #14097

Outline of Solution

sessions-table still emits the same reminder actions:
- remind all non-submitters
- remind selected non-submitters
instructor pages still listen to those events through sendRemindersToRespondentsEventHandler
shared handler now navigates to /web/instructor/sessions/:feedbackSessionId/send-reminders
it passes:
- preselectNonSubmitters=true for “remind all non-submitters”
- preselectNonSubmitters=false for “select non-submitters to remind”
- returnUrl so the page can navigate back after submit/cancel

on the new send-reminders page:

preselect non-submitters when requested
same selection controls as before
submit reminders directly through remindFeedbackSessionSubmissionForRespondents
navigate back with the success message preserved

cleanup and test coverage:

removed the old send-reminders modal component and model
added unit tests for selection behavior on the new page
added a dedicated InstructorSessionSendRemindersPageE2ETest and required page object
updated existing e2e tests (InstructorHomePage, InstructorFeedbackSession, InstructorFeedbackReport) to use the new send reminders page instead

Copilot

Pull request overview

Introduces a dedicated instructor “Send Reminders” page (replacing the previous modal) to better support large classes, while preserving existing reminder entry points from session-related instructor pages and updating test coverage accordingly.

Changes:

Added a new instructor route and standalone page for selecting respondents and sending submission reminders, with optional preselection of non-submitters and return navigation.
Refactored existing “send reminders” triggers to navigate to the new page instead of opening a modal / emitting modal results.
Removed the old send-reminders modal implementation and updated/added unit + E2E tests and page objects for the new flow.

Reviewed changes

Copilot reviewed 29 out of 29 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
src/web/app/pages-instructor/instructor.routes.ts	Registers the new `:feedbackSessionId/send-reminders` route.
src/web/app/pages-instructor/instructor-session-send-reminders-page/instructor-session-send-reminders-page.component.ts	Implements the new page: data loading, selection logic, reminder submission, safe return URL.
src/web/app/pages-instructor/instructor-session-send-reminders-page/instructor-session-send-reminders-page.component.html	New page UI: session details, selection controls, respondent table, actions.
src/web/app/pages-instructor/instructor-session-send-reminders-page/instructor-session-send-reminders-page.component.scss	Styles for the new page layout and controls.
src/web/app/pages-instructor/instructor-session-send-reminders-page/instructor-session-send-reminders-page.component.spec.ts	Unit tests for selection behavior, toggles, navigation, and error handling.
src/web/app/pages-instructor/instructor-session-result-page/instructor-session-result-page.component.ts	Removes now-obsolete reminder-sending logic previously tied to the modal response.
src/web/app/pages-instructor/instructor-session-result-page/instructor-session-result-page.component.html	Removes event binding previously used to send reminders via the modal workflow.
src/web/app/pages-instructor/instructor-session-result-page/instructor-session-no-response-panel.component.ts	Replaces modal opening with navigation to the new send-reminders page.
src/web/app/pages-instructor/instructor-session-result-page/instructor-session-no-response-panel.component.html	Updates “Remind All” button to use the new navigation handler.
src/web/app/pages-instructor/instructor-session-result-page/instructor-session-no-response-panel.component.spec.ts	Updates/extends tests to assert navigation to the send-reminders page.
src/web/app/pages-instructor/instructor-session-modal-page.component.ts	Updates shared reminder handler to navigate to the new page (with preselect + returnUrl).
src/web/app/components/sessions-table/send-reminders-to-respondents-modal/send-reminders-to-respondents-model.ts	Deletes old modal response model.
src/web/app/components/sessions-table/send-reminders-to-respondents-modal/send-reminders-to-respondents-modal.component.ts	Deletes old modal component.
src/web/app/components/sessions-table/send-reminders-to-respondents-modal/send-reminders-to-respondents-modal.component.html	Deletes old modal template.
src/web/app/components/sessions-table/send-reminders-to-respondents-modal/send-reminders-to-respondents-modal.component.scss	Deletes old modal styles.
src/web/app/components/sessions-table/send-reminders-to-respondents-modal/send-reminders-to-respondents-modal.component.spec.ts	Deletes old modal unit tests.
src/web/app/components/sessions-table/respondent-list-info-table/respondent-list-info-table.component.ts	Adds optional table label inputs for reuse on the new page.
src/web/app/components/sessions-table/respondent-list-info-table/respondent-list-info-table.component.html	Renders optional student/instructor labels above the tables.
src/main/java/teammates/common/util/Const.java	Adds a frontend URI constant for the new send-reminders page.
src/e2e/resources/testng-e2e.xml	Includes the new E2E test in the TestNG suite.
src/e2e/resources/data/InstructorSessionSendRemindersPageE2ETest.json	Adds data bundle for the new send-reminders page E2E test.
src/e2e/java/teammates/e2e/pageobjects/InstructorSessionSendRemindersPage.java	New page object encapsulating interactions/assertions for the send-reminders page.
src/e2e/java/teammates/e2e/pageobjects/InstructorHomePage.java	Updates reminder flows to use the new send-reminders page object.
src/e2e/java/teammates/e2e/pageobjects/InstructorFeedbackSessionsPage.java	Updates reminder flows to use the new send-reminders page object.
src/e2e/java/teammates/e2e/pageobjects/InstructorFeedbackResultsPage.java	Updates reminder flow to use the new send-reminders page object.
src/e2e/java/teammates/e2e/cases/InstructorSessionSendRemindersPageE2ETest.java	Adds dedicated E2E test for the new send-reminders page.
src/e2e/java/teammates/e2e/cases/InstructorHomePageE2ETest.java	Updates existing E2E assertions to follow the new reminder navigation flow.
src/e2e/java/teammates/e2e/cases/InstructorFeedbackSessionsPageE2ETest.java	Updates existing E2E assertions to follow the new reminder navigation flow.
src/e2e/java/teammates/e2e/cases/InstructorFeedbackReportPageE2ETest.java	Updates existing E2E assertions to follow the new reminder navigation flow.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

javieryeow · 2026-06-28T15:48:36Z

@samuelfangjw hi, was investigating the e2e test errors: InstructorHomePageE2ETest: "download results"

BaseE2ETestCase.verifyDownloadedFile is failing as the downloaded file could not be identified, and upon checking the downloads folder, the files are being saved as temporary download files that likely indicate the download is not being finalised (im using chrome so they appear as .com.google.Chrome.xxx). could i check if this is an existing issue or perhaps something to do with my test environment? im testing without my changes and the error seems to be happening as well.

samuelfangjw · 2026-06-29T06:05:54Z

BaseE2ETestCase.verifyDownloadedFile is failing as the downloaded file could not be identified, and upon checking the downloads folder, the files are being saved as temporary download files that likely indicate the download is not being finalised (im using chrome so they appear as .com.google.Chrome.xxx). could i check if this is an existing issue or perhaps something to do with my test environment? im testing without my changes and the error seems to be happening as well.

Hi @javieryeow, it's a known issue for chrome. Firefox is the only stable one at the moment. As long as it passes on CI it's ok.

Please also help to remove the added InstructorSessionSendRemindersPageE2ETest, updating the existing tests will do.

javieryeow · 2026-07-16T05:41:18Z

@samuelfangjw @TobyCyan hi sorry forgot to update: comments have been addressed previously!

TobyCyan · 2026-07-16T06:27:08Z

+
+.top-padded-sm {
+  padding-top: 10px;
+}


Please use bootstrap utility classes where applicable

bootstrap utility classes have been added, and these sections have been removed from the styles file

TobyCyan · 2026-07-16T06:40:51Z

        WebElement courseTab = getCourseTab(courseTabIndex);
        click(courseTab.findElement(By.className("btn-results-" + sessionIndex)));
-        click(waitForElementPresence(By.className("btn-download-" + sessionIndex)));
+        click(getVisibleDropdownAction("btn-download-" + sessionIndex));


Please revert this

changes reverted

TobyCyan · 2026-07-16T06:43:56Z

+        sendRemindersPage.verifyStatusMessage("Reminder e-mails have been sent out to those students"
                + " and instructors. Please allow up to 1 hour for all the notification emails to be sent out.");
+        homePage = sendRemindersPage.changePageType(InstructorHomePage.class);
+        homePage.sortCoursesByName();


Why is a sort needed here?

after we complete the send reminder email action, we navigate back to InstructorHomePage which is a fresh instance, hence it loses its sorted order above. after we navigate back to home page, sortCoursesByName is called so that downstream tests that use courseIndex can still target the correct courses and sessions

TobyCyan · 2026-07-16T06:52:29Z

+          />
+          <label for="sendCopyToIns" class="form-check-label">Send me a copy</label>
+        </span>
+        <button type="button" class="btn btn-light" (click)="cancel()">Cancel</button>


Shouldn't require a cancel button for a new page.

removed cancel button for send reminders page

TobyCyan · 2026-07-16T06:53:48Z

+
+  @Input({ required: true }) feedbackSessionId!: string;
+  @Input() preselectNonSubmitters = 'false';
+  @Input() returnUrl = '';


Shouldn't need returnUrl

removed returnUrl

Copilot AI review requested due to automatic review settings June 28, 2026 09:20

Copilot started reviewing on behalf of javieryeow June 28, 2026 09:21 View session

Copilot AI reviewed Jun 28, 2026

View reviewed changes

javieryeow added 12 commits June 30, 2026 00:20

Add optional section labels to respondent table

485b2f6

Replace send reminders modal with dedicated page

6ac4a59

Add send reminders page selection tests

2882771

Restore send reminders success toast after navigation

7fdcea6

Migrate reminder e2e flows to send reminders page

7e21d71

Add dedicated send reminders e2e coverage

b867fd6

Remove obsolete send reminders modal

1223aba

Fix lint errors

3396633

fix stale download button for InstHomePageE2ETest

86874e1

remove InstructorSessionsSendRemindersPageE2E

0abe453

chore: rerun ci

4f92e15

Fix send reminders spec after session visibility removal

b4df6bd

javieryeow force-pushed the feat/submission-reminders-page branch from dc7f20e to b4df6bd Compare June 29, 2026 16:23

javieryeow added 2 commits June 30, 2026 00:40

prevent sendReminders when user list empty

ce49b13

fixed send-reminders page styles

c99c07a

TobyCyan requested changes Jul 16, 2026

View reviewed changes

javieryeow added 8 commits July 18, 2026 21:56

apply bootstrap utility classes

c7fc49e

revert downloadResults for InstructorHomePage

5eb9c81

remove cancel button and update test

664f4f2

remove returnUrl from send reminders page

4a4f980

remove send reminder test to verify failure

7a2a857

comment out unused import

0c57216

fix lint issue

25e437f

use getNewPageInstance to reload page URL

25d3b28

move send reminders tests to the end

9125c9a

javieryeow requested a review from TobyCyan July 21, 2026 18:00

Uh oh!

Conversation

javieryeow commented Jun 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

javieryeow commented Jun 28, 2026

Uh oh!

samuelfangjw commented Jun 29, 2026

Uh oh!

javieryeow commented Jul 16, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TobyCyan Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

javieryeow commented Jun 28, 2026 •

edited

Loading

TobyCyan Jul 16, 2026 •

edited

Loading