[TASK] Detect duplicate table records within importCSVDataSet()
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbuerk
changed the title
uid or hash records for DataSet::import()uid or hash records for importCSVDataSet()
sbuerk
changed the title
uid or hash records for importCSVDataSet()importCSVDataSet()
The testing-frameworks provides the ability to read csv fixture files to import database datasets. The internal `DataSet::import()` implementation is provided by `FunctionalTestCase->importCSVDataSet()`. Sometimes duplicate rows with the same identifier (`uid` or `hash`) are included in a csv dataset file which are overriden. This change now checks during the dataseet import phase for these duplicates and throw a exception stating the table and id value to make the usage easier and helps with finding test-setup issues. Note: `assertCSVDataSet()` counter part will not check for duplicates. Resolves: #478 Releases: main, 7
lolli42
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The testing-frameworks provides the ability to read csv fixture
files to import database datasets. The internal
DataSet::import()implementation is provided by
FunctionalTestCase->importCSVDataSet().Sometimes duplicate rows with the same identifier (
uidorhash)are included in a csv dataset file which are overriden.
This change now checks during the dataseet import phase for these
duplicates and throw a exception stating the table and id value
to make the usage easier and helps with finding test-setup issues.
Note:
assertCSVDataSet()counter part will not check for duplicates.Resolves: #478
Releases: main, 7