feat(classifier): recognise 1Password YubiKey touches - #10
Draft
Talgarr wants to merge 3 commits into
Draft
Conversation
Talgarr
force-pushed
the
add-rule-1password
branch
from
June 25, 2026 16:28
53055e2 to
f818bbb
Compare
Name the touch when the 1Password desktop app or the "op" CLI is the toucher. Matches "1password"/"1Password"/"op" in the process tree and reports Tool=1password, Action=authenticate, Resource=1Password. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a manual e2e check (like the browser test): prompt for a 1Password unlock / `op signin` that touches the YubiKey and assert the classifier named `1password`. Register it in the driver and document it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The 1password e2e test drives `op`; add `_1password-cli` so it lands on PATH in `nix develop`. It is unfree, so enable config.allowUnfree. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Talgarr
force-pushed
the
add-rule-1password
branch
from
June 25, 2026 16:43
f818bbb to
e105c02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Name the touch when the 1Password desktop app or the "op" CLI is the toucher. Matches "1password"/"1Password"/"op" in the process tree and reports Tool=1password, Action=authenticate, Resource=1Password.