feat(classifier): recognise Bitwarden YubiKey touches - #11
Draft
Talgarr wants to merge 3 commits into
Draft
Conversation
Talgarr
force-pushed
the
add-rule-bitwarden
branch
from
June 25, 2026 16:29
ddc5e4c to
e85cdd8
Compare
Bitwarden supports a YubiKey OTP two-factor method. Both the desktop app (the `bitwarden` Electron binary) and the `bw` CLI prompt for the YubiKey OTP, and the key emits the one-time code on touch (HID OTP). Match either name and report an authenticate against the Bitwarden vault. WebAuthn/passkey unlock goes through the browser and is handled elsewhere. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add a manual e2e check (like the browser/1password tests): prompt for a Bitwarden unlock/login that uses the YubiKey OTP 2FA method and assert the classifier named `bitwarden`. Register it in the driver and document it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The bitwarden e2e test references `bw`; add `bitwarden-cli` so it lands on PATH in `nix develop`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Talgarr
force-pushed
the
add-rule-bitwarden
branch
from
June 25, 2026 16:43
e85cdd8 to
29eacf7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bitwarden supports a YubiKey OTP two-factor method. Both the desktop app (the
bitwardenElectron binary) and thebwCLI prompt for the YubiKey OTP, and the key emits the one-time code on touch (HID OTP). Match either name and report an authenticate against the Bitwarden vault. WebAuthn/passkey unlock goes through the browser and is handled elsewhere.