feat(classifier): recognise yubikey-agent PIV SSH touches - #14
Draft
Talgarr wants to merge 3 commits into
Draft
Conversation
Talgarr
force-pushed
the
add-rule-yubikey-agent
branch
from
June 25, 2026 16:29
bf8f061 to
690f1d7
Compare
yubikey-agent is a standalone PIV ssh-agent. The requesting ssh client talks to it over a UNIX socket, so it is not an ancestor in the touch process tree and the generic SSH rule misses it; this dedicated rule names the agent directly. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add an e2e check that starts yubikey-agent on a scratch socket and runs `ssh-add -T` against the PIV key it serves (the measured touch), asserting the classifier named `yubikey-agent`; the agent is killed after. Skips when yubikey-agent is absent or unprovisioned. Register it in the driver and document it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The yubikey-agent e2e test starts `yubikey-agent`; add it so it lands on PATH in `nix develop`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Talgarr
force-pushed
the
add-rule-yubikey-agent
branch
from
June 25, 2026 16:44
690f1d7 to
67040c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yubikey-agent is a standalone PIV ssh-agent. The requesting ssh client talks to it over a UNIX socket, so it is not an ancestor in the touch process tree and the generic SSH rule misses it; this dedicated rule names the agent directly.