feat(classifier): recognise ykman / Yubico Authenticator touches - #8
Draft
Talgarr wants to merge 2 commits into
Draft
feat(classifier): recognise ykman / Yubico Authenticator touches#8Talgarr wants to merge 2 commits into
Talgarr wants to merge 2 commits into
Conversation
OATH TOTP/HOTP codes that require touch blink the key on generation; ykman's PIV, FIDO and OpenPGP subcommands can also require a touch. Adds a rule matching the ykman CLI and the Yubico Authenticator GUI, parsing the CLI subcommand to report OATH code, PIV, FIDO, OpenPGP, OTP or management actions. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Add an e2e check that adds an ephemeral touch-required OATH credential, generates its code with `ykman oath accounts code` (the measured touch), and asserts the classifier named `ykman`; the credential is removed after. Skips when ykman is absent. Register it in the driver and document it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OATH TOTP/HOTP codes that require touch blink the key on generation; ykman's PIV, FIDO and OpenPGP subcommands can also require a touch. Adds a rule matching the ykman CLI and the Yubico Authenticator GUI, parsing the CLI subcommand to report OATH code, PIV, FIDO, OpenPGP, OTP or management actions.