Skip to content

chore: update knip - #11262

Open
TkDodo wants to merge 3 commits into
mainfrom
tkdodo/chore/update-knip
Open

chore: update knip#11262
TkDodo wants to merge 3 commits into
mainfrom
tkdodo/chore/update-knip

Conversation

@TkDodo

@TkDodo TkDodo commented Aug 23, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Chores

    • Updated internal code-quality tooling and its configuration.
    • Improved configuration-file scanning and validation rules.
    • Refreshed development tooling used during automated checks.
    • Strengthened automated checks for configuration-related issues.
  • Refactor

    • Reduced exposure of several internal TypeScript types without changing their behavior or constraints.
    • No user-facing functionality or API behavior was changed.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: ceb947c3-fa85-42d0-9069-a5185cbcc67e

📥 Commits

Reviewing files that changed from the base of the PR and between 923565f and b5e65fa.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

Knip now checks root-level configuration files and treats configuration and tag hints as errors. The Knip dependency and test script were updated. Three internal type declarations are no longer exported.

Changes

Knip and type visibility cleanup

Layer / File(s) Summary
Knip configuration and version update
knip.json, package.json
Knip now checks root configuration files and treats configuration and tag hints as errors. The development dependency and test:knip command were updated.
Internal type visibility cleanup
packages/lit-query/src/createQueriesController.ts, packages/preact-query/src/__tests__/ErrorBoundary/types.ts
CreateQueriesOptions and three ErrorBoundaryProps variants remain structurally unchanged but are no longer exported.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to b5e65

This dependency and configuration update has no actionable merge-blocking risk based on the available evidence and is merge-ready after normal checks and review.

Suggested reviewers: sheraff

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided, so the required changes, checklist, and release impact sections are missing. Add the required sections and describe the Knip changes, test status, and whether the change affects published code.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely identifies the primary change: updating the Knip configuration and dependency.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch tkdodo/chore/update-knip

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Aug 23, 2026

Copy link
Copy Markdown

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit dd9bbe3

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ❌ Failed 4m 39s View ↗
nx run-many --target=build --exclude=examples/*... ❌ Failed 32s View ↗

☁️ Nx Cloud last updated this comment at 2026-08-23 11:53:15 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@socket-security

socket-security Bot commented Aug 23, 2026

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedknip@​6.32.2991009596100

View full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant