refactor(start): streamline Rsbuild environment configuration - #8137
refactor(start): streamline Rsbuild environment configuration#8137SyMind wants to merge 7 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7a1a68888b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2199ef22b8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
This PR establishes a clearer Rsbuild configuration workflow for TanStack Start and fixes #7827.
flowchart LR D["Framework defaults<br/>Applied only when unset"] U["User config<br/>Native root and environment config"] E["Framework enforced config<br/>Applied last"] C{"Conflicts with<br/>an enforced value?"} W["Print warning with<br/>overridden paths"] F["Final Rsbuild config"] D -->|"lowest priority"| U U -->|"overrides defaults"| E E --> C C -->|"yes"| W C -->|"no"| F W --> FThe resulting precedence is:
Notable changes
assetPrefixinto the client environment, allowing root configuration and downstream plugins to work correctly.dev.assetPrefixandoutput.assetPrefix.rsbuild.client.outputand custom environment override abstractions.output.module.Testing