test(router-core): assert sequential asset projection - #8152
Conversation
|
View your CI Pipeline Execution ↗ for commit f21963d
☁️ Nx Cloud last updated this comment at |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds client-side and server-side tests for sequential parent-to-child projection of route metadata and scripts. The tests verify handler order, route context, projected assets, router state, and the server response. ChangesAsset projection order
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change adds focused coverage for sequential asset projection behavior without changing production code. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🚀 Changeset Version Preview5 package(s) bumped directly, 18 bumped as dependents. 🟩 Patch bumps
|
Bundle Size BenchmarksThis pull request does not affect bundle size in any measured scenario. |
Merging this PR will regress 8 benchmarks
|
Summary
headandscriptsprojection runs parent-to-childheadandscriptsprojection runs parent-to-childmatchesandmatchTests
tsc6 --noEmitSummary by CodeRabbit