[UI/#223] trip profile 구현 #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeeyubin
approved these changes
Mar 3, 2024
Comment on lines
+8
to
+9
| class TripProfileTagFragment : | ||
| BaseFragment<FragmentTripProfileTagBinding>(R.layout.fragment_trip_profile_tag) { |
Comment on lines
+165
to
+174
| <com.google.android.material.tabs.TabItem | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="@string/trip_profile_character" /> | ||
|
|
||
| <com.google.android.material.tabs.TabItem | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="@string/trip_profile_tag" /> | ||
| </com.google.android.material.tabs.TabLayout> |
There was a problem hiding this comment.
오,, 이렇게 TabItem을 둬서 text를 넣을 수 있군요,,?
저는 따로 textList를 만들어서 연결해줬던 것 같은데 찾아보니 두 방식 다 가능한 것 같네요!
There was a problem hiding this comment.
넹면 둘다 가능한데, 동적 선언이랑 정적 선언이랑 각자 이점이 있으니 더 살펴보고 작성하면 더 좋아요 ~~
There was a problem hiding this comment.
저는 해당 기능이 동적으로 하지 않아도 된다고 생각해서 정적으로 작성했습니다!
제가 올린 예시처럼 서버통신을 통해 동적으로 해야한다면 동적 선언이 더 이점이 있지만, 그게 아니라 저희 상황처럼 정적으로 되어있는 경우는 정적 선언이 더욱 좋다고 생각했습니다 :)
crownjoe
approved these changes
Mar 3, 2024
Comment on lines
+58
to
+59
| binding.tvProfileName.text.toString(), | ||
| binding.tvProfileOneLine.text.toString() |
There was a problem hiding this comment.
binding.~~ 이렇게 바로 인텐트로 보내니까 더 좋은 것 같아요!!
Marchbreeze
approved these changes
Mar 3, 2024
Comment on lines
+165
to
+174
| <com.google.android.material.tabs.TabItem | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="@string/trip_profile_character" /> | ||
|
|
||
| <com.google.android.material.tabs.TabItem | ||
| android:layout_width="wrap_content" | ||
| android:layout_height="wrap_content" | ||
| android:text="@string/trip_profile_tag" /> | ||
| </com.google.android.material.tabs.TabLayout> |
There was a problem hiding this comment.
넹면 둘다 가능한데, 동적 선언이랑 정적 선언이랑 각자 이점이 있으니 더 살펴보고 작성하면 더 좋아요 ~~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛳️ Work Description
📸 Screenshot
test.mp4
📢 To Reviewers
아 Empty VIew 안넣었다... 나중에 넣을게요 ㅎㅎㅎㅎㅎ