[fix] 식당 제보 validation 검증 조건 추가 #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,8 +29,8 @@ protected Store findByIdWithHeartAndIsDeletedFalse(final Long id) { | |||
| .orElseThrow(() -> new NotFoundException(StoreErrorCode.STORE_NOT_FOUND)); | |||
| } | |||
|
|
|||
| protected Optional<Store> findByLatitudeAndLongitudeWhereIsDeletedFalse(final double latitude, final double longitude) { | |||
| return storeRepository.findByPoint_LatitudeAndPoint_LongitudeAndIsDeletedFalse(latitude, longitude); | |||
| protected Optional<Store> findByLatitudeAndLongitudeAndNameWhereIsDeletedFalse(final double latitude, final double longitude, String name) { | |||
There was a problem hiding this comment.
통일성을 위해 name에도 final 키워드 붙이면 좋을 것 같아요!
| @@ -92,7 +92,7 @@ private boolean hasSameUserId(final Long id, final Heart heart) { | |||
|
|
|||
| @Transactional(readOnly = true) | |||
| public StoreDuplicateValidationResponse validateDuplicatedStore(final StoreValidationCommand command) { | |||
| return storeFinder.findByLatitudeAndLongitudeWhereIsDeletedFalse(command.latitude(), command.longitude()) | |||
| return storeFinder.findByLatitudeAndLongitudeAndNameWhereIsDeletedFalse(command.latitude(), command.longitude(), command.name()) | |||
| .map(store -> StoreDuplicateValidationResponse.of(store.getId(), universityStoreFinder.existsByUniversityIdAndStore(command.universityId(), store))) | |||
There was a problem hiding this comment.
이 부분 함수로 분리해서 가독성을 높이면 어떨지요,,.?
| @@ -3,6 +3,7 @@ | |||
| public record StoreDuplicateValidationRequest( | |||
| long universityId, | |||
| double latitude, | |||
| double longitude | |||
| double longitude, | |||
| String storeName | |||
There was a problem hiding this comment.
여기서 @notblank과 같은 어노테이션 등등이 있으면 빈 문자열이나 null을 거를 수 있을 것 같아용
Parkjyun
reviewed
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 📌
close #168
Description ✔️
To Reviewers
추가적으로 식당 삭제할 때 어떻게 처리할지에 대해 기획분들께 물어봤는데 릴리즈할 때까지 시간이 얼마 남지 않아 식당 삭제 제보가 들어오고 나서 재제보하는 것을 막지 않는다고 합니다. 때문에 식당 등록 로직에서 검증 로직 빼야할 것 같습니다.
hankki-server/src/main/java/org/hankki/hankkiserver/api/store/service/StoreCommandService.java
Lines 50 to 52 in e3f871d
이 부분 삭제해야함다. (지금 저 로직이 포함되어 있으면 삭제된 식당에 대한 재제보가 막히게돼요!)