[FEAT] MyPage 탭 UI 구현 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
string 추가
Feature/#11 my view my page
amourxyoung
approved these changes
Jul 14, 2023
| class ChooseProjectBottomFragment : | ||
| BottomSheetDialogFragment<FragmentBottomChooseProjectBinding>(R.layout.fragment_bottom_choose_project) { | ||
|
|
||
| private val dummyItemList = mutableListOf<ResponseMyPageProjectDto>( |
There was a problem hiding this comment.
p3) 되도록이면 데이터를 갖는 리스트는 뷰모델에 넣어주세용 !
There was a problem hiding this comment.
앗 더미데이터라고 걍 아무데나 넣었네용... 머쓱머쓱
| chooseProjectBottomFragment.show(requireActivity().supportFragmentManager, "show") | ||
| } | ||
| }) | ||
| val concatAdapter = ConcatAdapter(myRetroTopAdapter, myRetroAdapter) |
There was a problem hiding this comment.
어댑터명은 해당 뷰의 어떤 부분인지 확실하게 명시해주는게 좋을 것 같아요 ! ex) titleAdapter, contentAdapter
| }) | ||
| val concatAdapter = ConcatAdapter(myRetroTopAdapter, myRetroAdapter) | ||
|
|
||
| with(binding) { |
There was a problem hiding this comment.
Suggested change
| with(binding) { | |
| with(binding.rcvMyRetroMain) { |
| holder.onBind(nickName) | ||
| } | ||
|
|
||
| class TopViewHolder(private val binding: ItemMypageNicknameBinding) : |
There was a problem hiding this comment.
p2) viewHolder명은 어댑터명 그대로 가는게 좋습니당
There was a problem hiding this comment.
헉 왜 다르게 했지..? 짚어주셔서 감사해욧
|
mypage 패키지는 home 밖으로 빼주세용 피그마 파란 부분 기준으로 패키지 나누는걸로 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ 작업한 내용
✔️ PR point
📸 스크린샷
KakaoTalk_20230715_015818661.mp4
🍀 관련 이슈