Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] 아키텍처 구조 수정 #95

Merged
merged 13 commits into from
Aug 10, 2023

Conversation

amourxyoung
Copy link
Contributor

✍️ 작업한 내용

  • usecase 추가 후 해당 뷰모델 생성자에 usecase 주입
  • 리드미 스크린샷 수정
  • 수정된 api 대응

✔️ PR point

📸 스크린샷

🍀 관련 이슈

@amourxyoung amourxyoung self-assigned this Aug 10, 2023
Copy link
Member

@emjayMJkim emjayMJkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니당~~

class GetActionPlanUseCase @Inject constructor(private val repository: MyBoardRepository) {
suspend operator fun invoke(memberId: Int, projectId: Int) =
repository.getActionPlan(memberId, projectId)
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오 usecase.. 저도 클린 아키텍처 후다닥 적용해보겠습니당~~


import com.puzzling.puzzlingaos.data.model.response.ResponseTeamPuzzleBoardDto
import com.puzzling.puzzlingaos.data.model.response.ResponseTeamRankingDto
import com.puzzling.puzzlingaos.data.model.response.ResponseTeamReviewListDto

interface TeamReviewDataSource {
interface TeamDashBoardDataSource {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

네이밍 바꾼게 더 직관적이고 좋네용!!

@emjayMJkim emjayMJkim self-requested a review August 10, 2023 16:03
@amourxyoung amourxyoung merged commit e6cb9ed into Team-Puzzling:develop Aug 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants