[REFACTOR] entity 추가, dataStore 추가 #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew-Dto Refactor/Team-Puzzling#68 allview dto
…e-dataStore Refactor/Team-Puzzling#40 source data store
amourxyoung
approved these changes
Oct 3, 2023
| @@ -12,7 +13,7 @@ data class ResponseDetailRetroDto( | |||
| @SerialName("message") | |||
| val message: String, | |||
| @SerialName("data") | |||
| val data: Data?, | |||
|
|
||
| class KakaoLoginService(private val context: Context) { | ||
| class KakaoAuthService @Inject constructor(@ActivityContext private val context: Context) { |
There was a problem hiding this comment.
KakaoAuthService → LoginViewModel → LoginActivity 순으로 주입되고, kakaoAuthService에는
@ApplicationContext private val context: Context` 가 파라미터로 들어가 있는 코드를 처음에 작성했는데,,
Hilt의 ViewModel 주입은 Activity의 생명주기와 분리되어야 하기 때문에, ViewModel에서는 Activity Context를 직접 참조하거나 주입받아서는 안 된다고 합니다...! 이 원칙에 위반해서 안되던거더라구요,,,,,
| @@ -25,15 +26,15 @@ class DetailRetroAdapter() : | |||
|
|
|||
| inner class DetailRetroViewHolder(private val binding: ItemDetailRetroBinding) : | |||
| RecyclerView.ViewHolder(binding.root) { | |||
| fun onBind(item: ResponseDetailRetroDto.Data.DetailReviewData.Content) { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ 작업한 내용
✔️ PR point
📸 스크린샷
🍀 관련 이슈