Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#131 login onboarding UI #133

Merged
merged 8 commits into from
Oct 10, 2024
Merged

Feature/#131 login onboarding UI #133

merged 8 commits into from
Oct 10, 2024

Conversation

cacaocoffee
Copy link
Member

๐Ÿ“Œ PR ์š”์•ฝ

๐ŸŒฑ ์ž‘์—…ํ•œ ๋‚ด์šฉ

  • ๋กœ๊ทธ์ธ๊ณผ onboarding UI ๋ณ€๊ฒฝ

๐ŸŒฑ PR ํฌ์ธํŠธ

  • ๋‚˜์˜ค์ง€ ์•Š์€ ์ด๋ฏธ์ง€๋Š” ์ž„์˜๋กœ ๊ธฐ์กด์— ์“ฐ๋˜๊ฑฐ๋กœ ์‚ฌ์šฉํ–ˆ์Šต๋‹ˆ๋‹ค.

๐Ÿ“ธ ์Šคํฌ๋ฆฐ์ƒท

์Šคํฌ๋ฆฐ์ƒท
๊ฒฐ๊ณผ

๐Ÿ“ฎ ๊ด€๋ จ ์ด์Šˆ

@cacaocoffee cacaocoffee added ์Œˆ๋ฝ•ํ•œ UI ๋ช…์„ ๐Ÿ’กโœจ ๋ช…์„ํ•œ ์ฝ”๋”ฉ์„ ๋ณด์—ฌ์ฃผ๋งˆ labels Oct 7, 2024
@cacaocoffee cacaocoffee self-assigned this Oct 7, 2024
seohee0925
seohee0925 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@seohee0925 seohee0925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋„˜ ๊น”๊ผผํ•˜๋„ค์š” ๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค

feature/login/src/main/java/com/record/login/singup/SignUpScreen.kt
.size(
width = if (isSelected) indicatorWidth else indicatorNotSelectedWidth,
height = if (isSelected) indicatorHeight else indicatorNotSelectedHeight,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์—ฌ๊ธฐ์„œ width์™€ height๋ฅผ ์ด๋ ‡๊ฒŒ ์ง€์ •ํ•ด์ค€ ์ด์œ ๊ฐ€ ๊ถ๊ธˆํ•ฉ๋‹ˆ๋‹ค์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์„ ํƒ๋์„๋•Œ๋ž‘ ์•ˆ๋์„๋–„ ํฌ๊ธฐ๋ณ€ํ™”์žˆ์œผ๋ฉด ์ฒ˜๋ฆฌํ•˜๋ ค๊ตฌ ๋„ฃ์–ด๋‘” ์ฝ”๋“ ๋ฐ ํ”ผ๊ทธ๋งˆ์ƒ์— ํฌ๊ธฐ๋ณ€ํ™”๊ฐ€ ์—†์–ด์„œ ์—†์• ๋‘ ๋ ๊ฑฐ๊ฐ™๋„ค์š”

nagaeng
nagaeng reviewed Oct 10, 2024
View reviewed changes
feature/login/src/main/java/com/record/login/singup/screen/PolicyScreen.kt
RecordyCheckAllBox(
"์ „์ฒด ๋™์˜",
padding = padding,
checked = uiState.allChecked,
onClickEvent = { onCheckAllClick() },
)
Spacer(modifier = Modifier.height(8.dp))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

์š”๊ธฐ PolicyScreen ui ์˜์ƒ ๋ณด๋‹ˆ๊นŒ ํ”ผ๊ทธ๋งˆ๋ณด๋‹ค Checkbox ์ปดํฌ๋„ŒํŠธ ์‚ฌ์ด์˜ padding ๊ฐ’์ด ๋งŽ์ด ๋“ค์–ด๊ฐ„ ๊ฒƒ ๊ฐ™์€๋ฐ..!
RecordyCheckBox๊ฐ€ ์ปดํฌ๋„ŒํŠธ๊ฐ€ ์•„๋‹ˆ๋ผ ๋ฐ‘์— ํ•จ์ˆ˜๋กœ ๊ตฌํ˜„๋˜์–ด์žˆ๋Š” ๊ฒƒ ๊ฐ™์€๋ฐ height ํ•œ๋ฒˆ ํ™•์ธํ•ด๋ณด์…”์š”

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot_20241010_222957

์ˆ˜์ •ํ–ˆ์Šต๋‹ˆ๋‹ค! ๊ฐ์‚ฌํ•ด์š” ๋•๋ถ„์— ๋†“์ณค๋˜ ๋ถ€๋ถ„์„ ๋‹ค์‹œ์žก์•˜๋„ค์š”

nagaeng
nagaeng approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@nagaeng nagaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ตฟ ์ •์ฑ…์•ฝ๊ด€ ๋ถ€๋ถ„ ํŒจ๋”ฉ๊ฐ’ ํ™•์ธ๋งŒ ํ•ด์ฃผ์‹ฌ ๋ ๋“ฏํ•ฉ๋‹ˆ๋‹ค ๋‚˜๋จธ์ง€ LGTM~ โœจ

Sangwook123
Sangwook123 approved these changes Oct 10, 2024
View reviewed changes
Copy link
Contributor

@Sangwook123 Sangwook123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋‹จ์ˆœ ์ˆ˜์ •์ธ๊ฐ€์š”> ๊ณ ์ƒํ•˜์…ง์Šด๋‹ค~!

@cacaocoffee
Copy link
Member Author

cacaocoffee commented Oct 10, 2024 •
edited
Loading

๋‹จ์ˆœ ์ˆ˜์ •์ธ๊ฐ€์š”> ๊ณ ์ƒํ•˜์…ง์Šด๋‹ค~!

๋„ต ๋งž์Šต๋‹ˆ๋‹ค

@cacaocoffee cacaocoffee reopened this Oct 10, 2024
@cacaocoffee cacaocoffee merged commit 59046a0 into develop Oct 10, 2024
1 check passed
@cacaocoffee cacaocoffee deleted the feature/#131-login-onboarding-ui branch October 14, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seohee0925 seohee0925 seohee0925 approved these changes

@nagaeng nagaeng nagaeng approved these changes

@Sangwook123 Sangwook123 Sangwook123 approved these changes

@lsakee lsakee Awaiting requested review from lsakee

Assignees

@cacaocoffee cacaocoffee

Labels
๋ช…์„ ๐Ÿ’กโœจ ๋ช…์„ํ•œ ์ฝ”๋”ฉ์„ ๋ณด์—ฌ์ฃผ๋งˆ ์Œˆ๋ฝ•ํ•œ UI
Projects
None yet
Milestone
UI ์ž‘์—… ๋ฐ ๊ธฐ๋Šฅ ๊ตฌํ˜„
Development

Successfully merging this pull request may close these issues.

[feat] ๋กœ๊ทธ์ธ ๋ฐ ์˜จ๋ณด๋”ฉ ๋””์ž์ธ ๋ณ€๊ฒฝ
4 participants
@cacaocoffee @seohee0925 @nagaeng @Sangwook123