Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REFACTOR] FCM 외부 API 호출 인터페이스 분리 및 기타 리팩토링 #239

Merged
merged 15 commits into from
Mar 22, 2024

Conversation

thguss
Copy link
Member

@thguss thguss commented Mar 21, 2024

Related issue 🚀

Work Description 💚

  • 인터페이스 분리
  • FirebaseMessaging 기능 활용 (RestClient 미사용)
  • 푸시알림 전송 Single, Multicast 분리 (비동기로 속도 향상)
  • TrainingTimeRepository -> MemberRepository 쿼리 수정
  • 기타 리팩토링 반영

📮 이슈 (였던 것)

  • 스케줄러 미작동 이슈 대응했습니다!
  • api 모듈 내에서 dependencies와 componentScan에 batch 모듈 추가했습니다 :)
  • 스케줄러 작동 테스트 완료
  • 해당 PR 머지하면서, prod 싱크도 맞춰두겠습니다 :)

@thguss thguss added REFACTOR New feature or request SOHYEON 🐣 소현 작업 labels Mar 21, 2024
@thguss thguss requested a review from unanchoi March 21, 2024 17:55
@thguss thguss self-assigned this Mar 21, 2024
Copy link
Contributor

@unanchoi unanchoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

문제 없어 보입니다 ~ 고생하셨어요~

notification:
title: "오늘의 영어 훈련, 딱 5분 걸려요!"
body: "지금 눌러서 일기 쓰기 ✍️"
cron_expression: "0 0/30 * * * *"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

갑자기 궁금해졌는데, code 상에 별도로 Timezone을 명시 안했는데, 알람이 한국 시간 기준인 것은 서버 시간이 한국 시간으로 설정되어 있어서 그런거겠죠 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! TimezoneConfig를 통해서 디폴트 시각을 KST로 설정해두어서 그렇습니다!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아아 TimezonConfig 클래스를 만들어줬었죠 ㅋㅋㅋㅋ 굳이빈당

@thguss thguss merged commit 6eaf1cd into develop Mar 22, 2024
1 check passed
@thguss thguss deleted the sohyeon_#237 branch March 22, 2024 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REFACTOR New feature or request SOHYEON 🐣 소현 작업
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR] 외부 API 인터페이스 분리
2 participants