Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Service 계층에서 Adapter 계층을 의존하도록 리팩토링 #243

Merged
merged 6 commits into from
Apr 6, 2024
Merged

[REFACTOR] Service 계층에서 Adapter 계층을 의존하도록 리팩토링 #243

merged 6 commits into from
Apr 6, 2024

Conversation

unanchoi
Copy link
Contributor

Related issue 🚀

Work Description 💚

  • domain module에 adapter라는 계층을 만들어서, service에서 repository를 호출하는 것이 아닌 adapter 계층을 호출하도록 변경했습니다.
  • commit message를 수정하는 service 별로 분리하려고 했는데, service 별로 commit하기에는 좀 애매해서 한 번에 커밋했습니다 ..

@unanchoi unanchoi added REFACTOR New feature or request UNAN🐻 Unan 작업 labels Mar 23, 2024
@unanchoi unanchoi requested a review from thguss March 23, 2024 10:29
@unanchoi unanchoi self-assigned this Mar 23, 2024
thguss
thguss approved these changes Mar 23, 2024
View reviewed changes
Copy link
Member

@thguss thguss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
그런데 테스트 코드와 병행하기로 했던 것 같은데, 일단 구분하고 테스트 코드 작성하는 걸까요??
맞다면 저도 시작하기 위해 질문도 추가로 남깁니다~

smeem-domain/src/main/java/com/smeem/domain/badge/adapter/BadgeFinder.java
private final BadgeRepository badgeRepository;


public Badge findById(final long id) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

throwException 등과 같이 존재하지 않을 경우 예외를 발생시킨다는 의미를 메서드명에 추가하기로 했던 것 같아요!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅋㅋ그렇네요 맞춰서 수정할꼐용

@unanchoi
Copy link
Contributor Author

@thguss 맞네요 ..! Test Code까지 작성하여 추가로 push하겠습니다!

@unanchoi
Copy link
Contributor Author

unanchoi commented Apr 6, 2024

Test 코드 및 나머지 수정 부분은 이후에 수정하기위해서 우선 머지하겠습니다~

@unanchoi unanchoi merged commit 37645de into develop Apr 6, 2024
1 check passed
@unanchoi unanchoi deleted the refactor_#238 branch April 6, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thguss thguss thguss approved these changes

Assignees

@unanchoi unanchoi

Labels
REFACTOR New feature or request UNAN🐻 Unan 작업
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REFACTOR] domain module 내 구조 리팩토링
2 participants
@unanchoi @thguss