[CHORE] Sentry 설정 및 Discord 알람 설정 코드 변경 #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thguss
approved these changes
Mar 23, 2024
| @@ -26,6 +27,7 @@ public void send(final String content, final DiscordAlarmCase alarmCase) { | |||
| val restClient = RestClient.create(); | |||
| restClient.post() | |||
| .uri(webHookUri(alarmCase)) | |||
| .header(CONTENT_TYPE, "application/json; UTF-8") | |||
There was a problem hiding this comment.
application/json; UTF-8 요것도 ENUM 값이 없을까요!? application/json은 있었던 것 같아 일단 리뷰 남겨둡니다!
There was a problem hiding this comment.
Enum은 없고 각각의 +로 표현할 수 있는 것 같아서, 상수로 선언해두겠습니다 ~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚