-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Network] #248 - 피드상세뷰 내 드롭다운 UI 구현 및 API 연결 #295
Open
Guryss
wants to merge
12
commits into
main
Choose a base branch
from
Network/#248
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ena-isme
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
공용컴포넌튼데 분기처리가 까다로웠다니, 디테일한 부분 말씀주시면 반영해볼게요~
수고하셨습니다.
넹넹 노션에 적어놓을게염 !!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⭐️Issue
close #248
🌟Motivation
isMyFeed
여부에 따른 드롭다운 내 API 연결 및 기능 구현했습니다.🌟Key Changes
FeedDetailViewModel
내Input
,Output
정의Input은 드롭버튼 상하 버튼에 대한 Input 두개만 정의해두었습니다.
Output은
isMyFeed
가true
일 때 Output 2개,isMyFeed
가false
일 때 Output 2개, 총 4개로 정의해두었습니다.Output 이벤트 방출에 대한 분기처리를 해당
ViewModel
에 정의해두었습니다.WSS-iOS/WSSiOS/WSSiOS/Source/Presentation/FeedDetail/FeedDetailViewModel/FeedDetailViewModel.swift
Lines 111 to 133 in 5ccc88a
ViewController
bindViewModel
함수 내 API 호출항상 ViewModel에서 API 호출을 했었는데 이번엔 알럿이 뜬 후에 API 호출을 해야해서 뷰컨에서 호출해줬습니다.
더 좋은 방법이 있다면 많이 알려주세용 !
WSS-iOS/WSSiOS/WSSiOS/Source/Presentation/FeedDetail/FeedDetailViewController/FeedDetailViewController.swift
Lines 167 to 185 in 5ccc88a
🌟Simulation
효원이가 만들어준
pushFeedEdilViewController
함수에서 논의할 부분이 있어 반영되면 수정하기에서 데이터 넘기는 것까지 반영해보겠습니다.-> 효원이가 일단 feedId만 넘겨놓게 구현해두라고 했습니당.!!
ScreenRecording_10-16-2024.03-35-26_1.MP4
ScreenRecording_10-16-2024.03-06-23_1-2.mp4
🌟To Reviewer
🌟Reference