-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Working Oxygen Bubble Distributor #277
fix: Working Oxygen Bubble Distributor #277
Conversation
bf19214
to
4649fd7
Compare
I have also made some fixes to the Oxygen Sealer so that it acts correctly. To do this I have added a |
This PR is blocked by TeamGalacticraft/MachineLib#9, that is why builds are failing.
I have made the Oxygen Bubble Distributor work. To do this I have:
BubbleDistributorScreen
toOxygenBubbleDistributorScreen
bubbleVisible
to private which means that whensetBubbleVisible
is called I can pass that change back onto each client.oxygenRequired
to run the machine is less than 1 I now round up so that the machine properly turns off, a weird side effect is that most of the time the machine storage is left with 1 sliver of oxygenbubbleVisible
andsize
to theupdateTag
so that those values are persistent and will properly load in when the player joins the worldThere are also a number of other small changes to other oxygen systems.
I am not 100% sure about the networking aspect of my impl here in terms of efficiency and multiplayer (I can't test this aspect) so please double check that part.