-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LATCH-987 Fix Snackbar button color #304
Conversation
Screenshot tests report βοΈ All passing |
d3c015f
to
35ce5b7
Compare
static func misticaSnackbar( | ||
small: Bool = false, | ||
bleedingAlignment: ButtonBleedingAlignment = .none, | ||
withChevron: Bool = false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this should not be avalable as chevron is only available on link style
078b542
to
cc17c63
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
π
# [26.2.0](v26.1.0...v26.2.0) (2023-10-16) ### Bug Fixes * **Button:** change colors for disabled style ([#308](#308)) ([e829160](e829160)) * **Button:** change colors for disabled style ([#310](#310)) ([fb108a1](fb108a1)) * **Button:** Change cornerCurve from continuous to circular ([#307](#307)) ([26a73b3](26a73b3)) * **Snackbar:** change color for action button ([#304](#304)) ([7054e3d](7054e3d)) * **Tag:** change foreground and background colors according to specs ([#309](#309)) ([6a9f441](6a9f441)) ### Features * **Button:** Added accesibility to right image (chevron) ([05d77d9](05d77d9))
π This PR is included in version 26.2.0 π The release is available on GitHub release Your semantic-release bot π¦π |
ποΈ Jira ticket
https://jira.tid.es/browse/LATCH-987
π₯ What's the goal?
Component
Snackbar
is using tokentextLink
for its action button, instead of the right tokentextLinkSnackbar
π§ How do we do it?
Create new
MisticaButtonStyle
type called.misticaSnackbar
with the right color token.π§ͺ How can I verify this?