LATCH-1002: update text and background colors for Tag #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaranaz
requested review from
a team,
idenjoe,
alexanegon and
yceballost
and removed request for
a team
jaranaz
changed the title
idenjoe
reviewed
Oct 4, 2023
| @@ -104,7 +104,7 @@ public struct Tag: View { | |||
| case .inactive: | |||
| return .neutralMedium | |||
| case .warning: | |||
| return .warning | |||
| return .warningHigh | |||
There was a problem hiding this comment.
Maybe we should check all the styles and their corresponding token. In TagViewStyle(UIKit) we have different tokens for promo, active, success, error styles (and inverse that does not exist in SwiftUI?)
There was a problem hiding this comment.
I'm going to check on this, probably we will need to fix more than warning style
There was a problem hiding this comment.
Done! Now we have fixed the wrong colors, according to the specs document ;)
yceballost
approved these changes
Oct 5, 2023
alexanegon
approved these changes
Oct 5, 2023
jaranaz
force-pushed
the
LATCH-1002-fix-tag-text-color
branch
from
145845d
to
c4651d0
Compare
jaranaz
changed the title
alexanegon
approved these changes
Oct 9, 2023
idenjoe
approved these changes
Oct 9, 2023
tuentisre
pushed a commit
that referenced
this pull request
Oct 16, 2023
# [26.2.0](v26.1.0...v26.2.0) (2023-10-16) ### Bug Fixes * **Button:** change colors for disabled style ([#308](#308)) ([e829160](e829160)) * **Button:** change colors for disabled style ([#310](#310)) ([fb108a1](fb108a1)) * **Button:** Change cornerCurve from continuous to circular ([#307](#307)) ([26a73b3](26a73b3)) * **Snackbar:** change color for action button ([#304](#304)) ([7054e3d](7054e3d)) * **Tag:** change foreground and background colors according to specs ([#309](#309)) ([6a9f441](6a9f441)) ### Features * **Button:** Added accesibility to right image (chevron) ([05d77d9](05d77d9))
|
🎉 This PR is included in version 26.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/LATCH-1002
🥅 What's the goal?
The
Tagcomponent is not using the right text and background colors for its styles, according to the specs for this component.🚧 How do we do it?
Fix
Tagcomponent colors in both UIKit and SwiftUI.🏑 AppCenter build