-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IOS-9386] Building with XCode 15 #315
[IOS-9386] Building with XCode 15 #315
Conversation
@alejandroruizponce where is the app? Remember to upload it in the Alpha slot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but I just have a question, do you think it is in our interest to add a tolerance margin to avoid uploading images that are actually almost identical?
It won't solve this kind of PRs :( since you record the test and the result is different (new screenshot needs to be commited :() |
Ok, now it's uploaded in alpha. I had uploaded it in enterprise instead. |
π This PR is included in version 26.3.0 π The release is available on GitHub release Your semantic-release bot π¦π |
ποΈ Jira ticket
https://jira.tid.es/browse/IOS-9386
π₯ What's the goal?
Build and integrate with XCode 15 and iOS 17 now we have slaves updated with that version.
π§ How do we do it?
Update configuration in Makefile with a new simulator iPhone 15 in iOS 17.0 and using XCode 15 app.
Compiling with XCode 15 and on iPhone 15 misaligns some tiny pixels in the snapshots which requires that many of them have been re-generated with little difference.
π§ͺ How can I verify this?
Check CI tests and new catalog version generated.