Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IOS-9386] Building with XCode 15 #315

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

alejandroruizponce
Copy link
Contributor

🎟️ Jira ticket

https://jira.tid.es/browse/IOS-9386

πŸ₯… What's the goal?

Build and integrate with XCode 15 and iOS 17 now we have slaves updated with that version.

🚧 How do we do it?

Update configuration in Makefile with a new simulator iPhone 15 in iOS 17.0 and using XCode 15 app.

Compiling with XCode 15 and on iPhone 15 misaligns some tiny pixels in the snapshots which requires that many of them have been re-generated with little difference.

πŸ§ͺ How can I verify this?

Check CI tests and new catalog version generated.

@amegias
Copy link
Contributor

amegias commented Oct 18, 2023

@alejandroruizponce where is the app? Remember to upload it in the Alpha slot
https://appcenter.ms/orgs/Tuenti-Organization/apps/Mistica-SwiftUI-iOS

Copy link
Contributor

@DavidMarinCalleja DavidMarinCalleja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I just have a question, do you think it is in our interest to add a tolerance margin to avoid uploading images that are actually almost identical?

@amegias
Copy link
Contributor

amegias commented Oct 18, 2023

Looks good to me, but I just have a question, do you think it is in our interest to add a tolerance margin to avoid uploading images that are actually almost identical?

It won't solve this kind of PRs :( since you record the test and the result is different (new screenshot needs to be commited :()
I would avoid testing for all brands in some cases which are not interesting

@alejandroruizponce
Copy link
Contributor Author

@alejandroruizponce where is the app? Remember to upload it in the Alpha slot https://appcenter.ms/orgs/Tuenti-Organization/apps/Mistica-SwiftUI-iOS

Ok, now it's uploaded in alpha. I had uploaded it in enterprise instead.

@alejandroruizponce alejandroruizponce merged commit e9bbd17 into main Oct 19, 2023
4 checks passed
@alejandroruizponce alejandroruizponce deleted the IOS-9386-Test-and-build-with-XCode-15 branch October 19, 2023 11:38
@tuentisre
Copy link
Collaborator

πŸŽ‰ This PR is included in version 26.3.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants