Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iOS 10309 crouton on screen #382

Merged
merged 5 commits into from
Jul 26, 2024
Merged

Conversation

WanaldinoTelefonica
Copy link
Contributor

🎟️ Jira ticket

IOS-10309

πŸ₯… What's the goal?

  • Allow crouton to be shown in a specific viewController

🚧 How do we do it?

  • Store the viewController on the ongoingCroutons (weak reference as we don't want to retain it)
  • If the viewController is defined, don't look for the top most viewController

πŸ§ͺ How can I verify this?

πŸ‘ AppCenter build

@WanaldinoTelefonica WanaldinoTelefonica marked this pull request as ready for review July 19, 2024 08:21
@WanaldinoTelefonica WanaldinoTelefonica requested review from a team, idenjoe and dhidalgofadrique and removed request for a team July 19, 2024 08:21
Copy link
Contributor

@dhidalgofadrique dhidalgofadrique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

@WanaldinoTelefonica WanaldinoTelefonica merged commit 8e1bd80 into main Jul 26, 2024
2 checks passed
@WanaldinoTelefonica WanaldinoTelefonica deleted the IOS-10309-Crouton-on-screen branch July 26, 2024 08:40
@tuentisre
Copy link
Collaborator

πŸŽ‰ This PR is included in version 31.4.0 πŸŽ‰

The release is available on GitHub release

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants