IOS-10414 Add Skeleton components in SwiftUI and UIKit #388
Conversation
| public enum SkeletonType { | ||
| case line(width: CGFloat) | ||
| case text(numberOfLines: Int = 3) | ||
| case circle(size: CGFloat) | ||
| case row | ||
| case rectangle(size: CGSize, isRounded: Bool) | ||
| } |
There was a problem hiding this comment.
maybe I would have a LineSkeletonView, TextSkeletonView,... to avoid executing a switch eeeeverytime.
If you know the type you need, you are able to call the right View :/
There was a problem hiding this comment.
Mmm, I don't necessarily agree. IMO for such simple views that share common attributes between them and that are even reused in certain types it makes more sense to have them centralized. It brings consistency.
In the case of a higher level of complexity in the views and contain significant differences between them if I could agree to separate them.
But right now I see no compelling reasons, neither of testability nor of readability. WDTY?
| } | ||
|
|
||
| public var body: some View { | ||
| switch type { |
There was a problem hiding this comment.
same. we are executing this switch every time the view is rendered. Why don't you create several views?
|
|
||
| final class SkeletonTests: XCTestCase { | ||
| override class func setUp() { | ||
| isRecording = false |
There was a problem hiding this comment.
what about the snapshots? I couldn't find them...
There was a problem hiding this comment.
I was waiting for the approval to launch the GH action of the record. But maybe it helps to see the snapshots already to review.
There was a problem hiding this comment.
yes, it could help, thanks!
| override class func setUp() { | ||
| super.setUp() | ||
|
|
||
| isRecording = false |
There was a problem hiding this comment.
what about the snapshots? I couldn't find them...
| public struct Skeleton: View { | ||
| enum Constants { | ||
| static var lineHeight = 8.0 | ||
| static var radius = 8.0 |
There was a problem hiding this comment.
Radius should use tokens. Was our mistake because the specs were not defined well
There was a problem hiding this comment.
You're right, I didn't remember it either although I didn't see it in the specs. Fixed!
|
Record screenshots on PR comment: succeeded ✅ |
|
Screenshot tests report ✔️ All passing |
|
Record screenshots on PR comment: succeeded ✅ |
|
🎉 This PR is included in version 31.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10414
🥅 What's the goal?
Implement the native Skeletons components designed by Mistica in the following spec:
https://www.figma.com/design/w7E0mmB92eio0zHw7h9iS2/%F0%9F%94%B8-Skeletons-Specs?node-id=986-1161&t=SJOFSJMtw5Mmpp22-0
🚧 How do we do it?
The following changes have been made:
🧪 How can I verify this?
A version of the MisticaCatalog has been generated to test and visualize the Skeletons.
🏑 AppCenter build
(Jul 22, 2024 at 17:56)
