IOS-10545 Update Makefile with XCode 16 #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alejandroruizponce
changed the title
alejandroruizponce
force-pushed
the
IOS-10545-Update-Makefile-to-XCode-16
branch
from
a7b72c0
to
38a1773
Compare
|
Record screenshots on PR comment: succeeded ✅ |
There was a problem hiding this comment.
it's weird but if you notice the new circle is painted worse than the old one. The old one has an “anti aliasing” effect and the new one has sawtooths in some areas.
There was a problem hiding this comment.
Yes, this is something that happens with XCode 16... I have seen in the snapshot testing repo that there are people with the same problem and it is not clear what the solution is... I have tried several things but I think I will have to wait for a future version of snapshot to fix this bug.
There was a problem hiding this comment.
the same in this case, the circle is not pixel perfect
DavidMarinCalleja
approved these changes
Oct 8, 2024
idenjoe
approved these changes
Oct 11, 2024
alejandroruizponce
requested review from
a team and
marinitx
and removed request for
a team
marinitx
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Jira ticket
https://jira.tid.es/browse/IOS-10545
🥅 What's the goal?
Build and integrate with XCode 16 and iOS 18 now we have slaves updated with that version.
🚧 How do we do it?
Update configuration in Makefile with a new simulator iPhone 16 in iOS 18.0 and using XCode 16 app.
Compiling with XCode 16 and on iPhone 16 misaligns some tiny pixels in the snapshots which requires that many of them have been re-generated with very little difference.
🧪 How can I verify this?
There are many tests that have been updated probably due to variations of 1px or less, this is something that already happened with iOS 17 back in the day, I recommend checking them from Sourcetree or similar as the Github page will freeze trying to load so many snapshots.
For Design review: A release for Mistica Catalog has been generated in Alpha Mistica-SwiftUI-iOS app center project.