fix(type): type error in config #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
这样可以吗 |
但是还有一个就是自定义的按钮咋办，他们不在这个范围内。。 |
看下这样是否可以解决，获取customMenu中用户自定义的key值，用于CherryInsertToolbar的校验 |
我试一下 |
|
😞😞目前怎么推导 type CherryTopToolbarKeys =
| 'bold'
| 'italic'
| 'strikethrough'
| 'color'
| 'header'
| 'list'
| 'image'
| 'audio'
| 'video'
| 'link'
| 'hr'
| 'br'
| 'code'
| 'formula'
| 'toc'
| 'table'
| 'pdf'
| 'word'
| 'graph'
| 'settings'
| 'insert';
export type CherryToolbarSeparator = '|';
type CustomToolbarKeys = keyof CherryToolbarOptions['customMenu'];
export type CherryDefaultToolbar =
| CherryInsertToolbar
| CherryToolbarSeparator
| CherryTopToolbarKeys;
export type CherryInsertToolbar = {
[key in CherryTopToolbarKeys & CustomToolbarKeys]?: string[];
}; |
|
@Saraph1nes |
1 similar comment
2 similar comments
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
在
toolbar中 设置包含二级菜单栏的时候，遇到一级菜单栏错误。这里设置成了
string类型进行通配，但是感觉这种失去了约束力。你有空给看下，怎么设置这个类型比较好@lyngai