Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(descriptions): add descriptions components #1492

Closed
wants to merge 3 commits into from

Conversation

RSS1102
Copy link
Contributor

@RSS1102 RSS1102 commented Jul 1, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

📝 更新日志

  • fix(组件名称): 处理问题或特性描述 ...

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@RSS1102
Copy link
Contributor Author

RSS1102 commented Jul 1, 2023

@uyarn 请帮忙review一下。

@uyarn uyarn changed the title feat(descriptions): init feat(descriptions): add descriptions components Jul 2, 2023
@uyarn
Copy link
Collaborator

uyarn commented Jul 4, 2023

@uyarn
Copy link
Collaborator

uyarn commented Jul 4, 2023

api 再补充一份 descriptions.en-US.md 的英文文档

}
}

.@{prefix}-descriptions-item-label-left {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个的class也不太规范 参考下BEM规范调整下 下面其他的也需要调整下

@RSS1102
Copy link
Contributor Author

RSS1102 commented Jul 13, 2023

修复一下 stylelint 的错误 https://github.com/Tencent/tdesign-common/actions/runs/5433393047/jobs/9884646499?pr=1492

文档示例 我只补充了一个基础示例,我想过了代码之后再进行补充?

@uyarn uyarn closed this Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants