fix(TimePicker): 修复使用px to rem插件时大分辨率下下mask不能居中的问题 #1520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
为什么这样子就不会有问题呢？ |
|
tdesign-vue preview 地址：（如果你有 DOM 变动请自行在对应技术栈仓库中发起 PR） |
确实还会存在问题，抱歉，这条pr不太严谨，麻烦先关闭，谢谢 |
可以再讨论的 我不太清楚问题的具体表现是什么 能不能看看截个图转成rem之后是什么CSS样式？ |
会有略微错位，样式和效果看下图 CSS样式 在4800*1620分辨率下显示的效果，此时1rem等于21.6px |
我猜应该是因为取整的关系？ |
|
我也觉得可能是，之前提交过一次 pr 就是修复取整问题的，在那之前错位更严重 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
使用px to rem插件时，在大分辨率下mask会出现无法居中的情况，此PR优化了mask居中相关的样式代码，无其他影响。
📝 更新日志
fix(TimePicker): 修复使用px to rem插件时大分辨率下下mask不能居中的问题
fix(组件名称): 处理问题或特性描述 ...
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单