Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]feat(Button): sync mobile-vue to react-vue #439

Closed
wants to merge 0 commits into from

Conversation

tobytovi
Copy link
Collaborator

@tobytovi tobytovi commented Aug 7, 2024

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

💡 需求背景和解决方案

同步 tdesign-mobile-vue 能力到 tdesign-mobile-react
使其能力一致,本次同步Button组件部分

📝 更新日志

  • fix(Button): 同步tdesign-mobile-vue的Button组件样式到tdesign-mobile-react

  • fix(Demo): 同步tdesign-mobile-vue的Button的演示样式到tdesign-mobile-react

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@tobytovi tobytovi changed the title feat(Button): sync mobile-vue to react-vue [WIP]feat(Button): sync mobile-vue to react-vue Aug 12, 2024
Copy link
Collaborator

@HaixingOoO HaixingOoO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

const Button = forwardRef((props: ButtonProps, ref: React.Ref<HTMLButtonElement>)
// 改成下面这样统一吧
const Button = forwardRef<HTMLButtonElement,ButtonProps>((props, ref)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不用改,在 common 那边把 api_v2 里两个 button.md 复制到 api 即可

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经新的PR中更改
#464

@tobytovi
Copy link
Collaborator Author

const Button = forwardRef((props: ButtonProps, ref: React.Ref<HTMLButtonElement>)
// 改成下面这样统一吧
const Button = forwardRef<HTMLButtonElement,ButtonProps>((props, ref)

已经新的PR中更改 @HaixingOoO
#464

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants