Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Popconfirm): button props propagation #2361

Merged
merged 2 commits into from
Jul 18, 2023

Conversation

imp2002
Copy link
Contributor

@imp2002 imp2002 commented Jul 12, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#2360

💡 需求背景和解决方案

confirmBtn/cancelBtn 值类型为 Object 时未透传。

image

修改后测试结果:

image
<Popconfirm theme={'default'} 
  content={'您确定要提交吗'} 
  confirmBtn={'确认提交'} 

  // object 透传
  cancelBtn={{onClick: ()=>{console.log("test")}, content: "test", theme: "danger"}}
>
  <Button theme="default" variant="outline">
    按钮样式(属性-字符串)
  </Button>
</Popconfirm>

📝 更新日志

  • fix(Popconfirm): 当 confirmBtn/cancelBtn 值类型为 Object 时未透传

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

when `confirmBtn/cancelBtn` value is `object` props propagation invalid
@github-actions
Copy link
Contributor

github-actions bot commented Jul 12, 2023

完成

@imp2002 imp2002 requested a review from honkinglin July 13, 2023 08:17
@uyarn uyarn merged commit 13f6b16 into Tencent:develop Jul 18, 2023
5 checks passed
@github-actions github-actions bot mentioned this pull request Jul 19, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants