Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tag-input): fix input value was blocked when enter Chinese #2438

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix(tag-input): fix input value was blocked when enter Chinese #2438

merged 1 commit into from
Aug 18, 2023

Conversation

HaixingOoO
Copy link
Collaborator

@HaixingOoO HaixingOoO commented Aug 14, 2023

🤔 这个 PR 的性质是?

  • 日常 bug 修复
  • 新特性提交
  • 文档改进
  • 演示代码改进
  • 组件样式/交互改进
  • CI/CD 改进
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他

🔗 相关 Issue

#2437

💡 需求背景和解决方案

1.修復沒監聽拼音輸入,設置input寬度

📝 更新日志

  • fix(taginput): fix when entering Chinese, it will be blocked by the previous label

  • 本条 PR 不需要纳入 Changelog

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项⚠️

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

@github-actions
Copy link
Contributor

完成

@uyarn
Copy link
Collaborator

uyarn commented Aug 16, 2023

@Zzongke 看起来是这个问题 我们验证下 这个组件是很多组件的底层依赖 合并得谨慎点

@uyarn uyarn changed the title fix(taginput): fix when entering Chinese, it will be blocked by the p… fix(tag-input): fix input value was blocked when enter Chinese Aug 16, 2023
@HaixingOoO
Copy link
Collaborator Author

@Zzongke看起来是这个问题我们验证下这个组件是很多组件的基础依赖餐饮得珍珠点

是的,還是需要謹慎點

Copy link
Collaborator

@uyarn uyarn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@uyarn uyarn merged commit 723acae into Tencent:develop Aug 18, 2023
5 checks passed
@HaixingOoO HaixingOoO deleted the fix/taginput branch August 24, 2023 02:34
@github-actions github-actions bot mentioned this pull request Aug 24, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants