fix(table): fix table add resizable, turn page no save width #2575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HaixingOoO
requested review from
honkinglin,
uyarn and
carolin913
as code owners
|
|
added 2 commits
November 1, 2023 15:24
chaishi
reviewed
Nov 2, 2023
| const cols = getColumns(columns); | ||
| if (showExpandIconColumn) { | ||
| cols.unshift(getExpandColumn()); | ||
| } | ||
| return cols; | ||
| })(); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| }, [columns, showExpandIconColumn]); |
There was a problem hiding this comment.
此处需添加 getColumns 中的更多依赖，如： tDisplayColumns props.columnController props.showSortColumnBgColor props.sort primaryTableRef.current?.tableContentRef 等等，可能需要再仔细确认下
方便的话，验证一下列配置、表头吸顶、虚拟滚动等场景是否正常
There was a problem hiding this comment.
外层太多影响Columns的，不好解决这个依赖的问题，要么导出个重置宽度的事件，这图里的注释掉，让用户自己处理要不要重置宽度是不是好点？
There was a problem hiding this comment.
可以，我试试在分页触发的时候读取保存好的宽度
那你解决了，后面把我这个PR关闭就好
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
Table组件，resizable开启后，翻页之后各列宽度未能保存。
使用useMemo来优化columns。
📝 更新日志
fix(table): 修复表格组件，可调整大小开启后，翻页之后各列宽度未能保存。
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单