Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Tabs): fix tabs tabPanel label change tabbar not update #3134

Merged
merged 1 commit into from
Oct 14, 2024
Merged

fix(Tabs): fix tabs tabPanel label change tabbar not update #3134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/tabs/TabBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,17 @@ import React, { useEffect, useState, CSSProperties, useRef } from 'react';
import classNames from 'classnames';
import useConfig from '../hooks/useConfig';
import useMutationObserver from '../hooks/useMutationObserver';
import useResizeObserver from '../hooks/useResizeObserver';

interface TabBarProps {
tabPosition: string;
activeId: string | number;
containerRef: React.MutableRefObject<HTMLDivElement>;
navsWrapRef: React.MutableRefObject<HTMLDivElement>;
}

const TabBar: React.FC<TabBarProps> = (props) => {
const { tabPosition, activeId, containerRef } = props;
const { tabPosition, activeId, containerRef, navsWrapRef } = props;
const { classPrefix } = useConfig();
const [barStyle, setBarStyle] = useState<CSSProperties>({});
const tabsClassPrefix = `${classPrefix}-tabs`;
Expand Down Expand Up @@ -66,6 +68,8 @@ const TabBar: React.FC<TabBarProps> = (props) => {

useMutationObserver(containerRef.current, handleMutationObserver);

useResizeObserver(navsWrapRef.current, computeStyle);

return (
<div
className={classNames({
Expand Down
2 changes: 1 addition & 1 deletion src/tabs/TabNav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ const TabNav: React.FC<TabNavProps> = (props) => {

// TabBar 组件逻辑层抽象，卡片类型时无需展示，故将逻辑整合到此处
const TabBarCom = isCard ? null : (
<TabBar tabPosition={placement} activeId={activeIndex} containerRef={navsWrapRef} />
<TabBar tabPosition={placement} activeId={activeIndex} containerRef={navsWrapRef} navsWrapRef={navsWrapRef} />
);

const handleTabItemRemove = (removeItem) => {
Expand Down
Loading