Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle the clearAll flag in RenderTargetCreateTask instead of creating a ClearOp. #283

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Handle the clearAll flag in RenderTargetCreateTask instead of creating a ClearOp. #283

merged 1 commit into from
Oct 29, 2024

Conversation

domchen
Copy link
Collaborator

@domchen domchen commented Oct 29, 2024

在创建RenderTarget的时候执行清屏，避免额外产生一个ClearOp。另外OpContext被Surface持有了，它的析构函数不应该存在访问context的情况。

@Hparty Hparty merged commit 624fb1f into main Oct 29, 2024
8 checks passed
@Hparty Hparty deleted the feature/domchen_clear branch October 29, 2024 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hparty Hparty Hparty approved these changes

@kevingpqi123 kevingpqi123 Awaiting requested review from kevingpqi123 kevingpqi123 is a code owner

@lvpengwei lvpengwei Awaiting requested review from lvpengwei lvpengwei is a code owner

@shlzxjp shlzxjp Awaiting requested review from shlzxjp shlzxjp is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domchen @Hparty