Add an interface to the Path to support constructing Path using SVG #284
Conversation
YGaurora
requested review from
domchen,
Hparty,
lvpengwei and
shlzxjp
as code owners
include/tgfx/core/Path.h
Outdated
| /** | ||
| * Returns last point on Path in lastPt. Returns false if point array is empty. | ||
| */ | ||
| bool getLastPt(Point* lastPt) const; |
There was a problem hiding this comment.
避免使用缩写，getlastPoint()，参数lastPt也对应修改一下。
There was a problem hiding this comment.
这个接口是外部要调用还是只是我们内部实现arcTo函数需要？如果只是内部需要，我们直接访问PathKit的接口就行，不用暴露这个公开接口。
There was a problem hiding this comment.
只是内部需要，但是我认为这个接口还是对用户来说有价值的，比如现有的addArc其实不需要输入结束点，在add后需要知道终点是哪儿还需要自己计算。
There was a problem hiding this comment.
并且是为了svg模块去使用，也算是外部的调用
include/tgfx/core/Path.h
Outdated
| * Point and (x, y) if both are greater than zero but too small. | ||
| * arcTo() appends up to four conic curves. | ||
| * arcTo() implements the functionality of SVG arc, although SVG sweep-flag value is opposite the | ||
| * integer value of sweep; SVG sweep-flag uses 1 for clockwise,while counter-clockwise direction |
There was a problem hiding this comment.
这里应该是指的svg里面的参数
There was a problem hiding this comment.
用Github Copilot重写一下这段注释吧，prompt：Rewrite it to sound more natural for a native speaker.
include/tgfx/core/Path.h
Outdated
| * @param xAxisRotate x-axis rotation in degrees; positive values are clockwise | ||
| * @param largeArc chooses smaller or larger arc | ||
| * @param reversed Choose the rotation clockwise direction.（clockwise = false） | ||
| * @param endPt end of arc |
include/tgfx/core/PathTypes.h
Outdated
| /** | ||
| * Specify whether the arc is greater than 180 degrees pair or less than 180 degrees pair. | ||
| */ | ||
| enum class ArcSize : uint8_t { |
src/core/Path.cpp
Outdated
| Matrix pointTransform; | ||
| pointTransform.setRotate(-xAxisRotate); |
There was a problem hiding this comment.
可以合并为 auto pointTransform = Matrix::MakeRotate()
src/core/Path.cpp
Outdated
| Matrix pointTransform; | ||
| pointTransform.setRotate(-xAxisRotate); | ||
|
|
||
| Point transformedMidPoint; |
There was a problem hiding this comment.
声明变量都记得赋初始值 Point::Zero(), 不然很多隐藏bug。
| bool Path::getLastPoint(Point* lastPoint) const { | ||
| SkPoint skPoint; | ||
| if (pathRef->path.getLastPt(&skPoint)) { | ||
| lastPoint->set(skPoint.fX, skPoint.fY); |
There was a problem hiding this comment.
这里对lastPoint的指针访问是否需要判空？检查一下PathKit里的对应实现是否判空，如果那边判空了，这里也要加上。
include/tgfx/core/PathTypes.h
Outdated
| Small_ArcSize, | ||
| /** | ||
| * larger of arc pair | ||
| */ | ||
| Large_ArcSize, |
There was a problem hiding this comment.
把_ArcSize后缀去掉，Skia里这么命名是因为没有使用enum class，怕重名。
src/core/Path.cpp
Outdated
| Matrix pointTransform = Matrix::MakeRotate(-xAxisRotate); | ||
| Point transformedMidPoint = Point::Zero(); |
There was a problem hiding this comment.
类型声明推荐尽可能多使用auto，让编译器推理，可读性也更好。
src/core/Path.cpp
Outdated
| @@ -415,4 +542,15 @@ int Path::countPoints() const { | |||
| int Path::countVerbs() const { | |||
| return pathRef->path.countVerbs(); | |||
| } | |||
|
|
|||
| bool Path::getLastPoint(Point* lastPoint) const { | |||
| if (!lastPoint) return false; | |||
There was a problem hiding this comment.
避免写这种单行if的代码，严格都加上大括号，不然if条件去掉容易出别的bug。代码是写给人类阅读的，不用节省行数。
Support SVG-style arc descriptions.
Get the last point of the Path.