Osmotic Enchanter doesn't lose your settings when you add/remove a wand before starting enchantment #1054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd before starting enchantment
|
This one will need more testing before it is PR'd, as this is for an older version this will take more then a couple days. The previous behaviour was due to exploits that occurred, and I need to make sure it does not re-introduce them, or if people are having trouble, find a new way to patch |
|
That's more than fair! Thank you for the prompt responses! Do you have any additional information regarding the nature of the exploits in question? |
…nd before starting enchantment Revert "Osmotic Enchanter doesn't lose your settings when you add/remove a wand before starting enchantment" This reverts commit 6eb0013. Revert "Revert "Osmotic Enchanter doesn't lose your settings when you add/remove a wand before starting enchantment"" This reverts commit 01f6bd80f2511bccee723a396c1b74381c3b410f.
…com/SarahKirksey/ThaumicTinkerer into 1.7-final-OsmoticEnchanterWandTweak
…nd before starting enchantment
…com/SarahKirksey/ThaumicTinkerer into 1.7-final-OsmoticEnchanterWandTweak
For some unidentified reason, the last attempt broke the enchanter entirely. This approach should function as intended and offer better performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't tell you how many times I've configured a tool or weapon with the perfect enchantment set, realized there's no wand in the table, and added a wand before clicking the button to start the enchantment. Every time, I died a little inside. I've spoken with others, and the ones who have also done this have agreed that this behavior is not desired. Since I was modifying the code to fix the Infused Seeds bugs, adding one more change to the mix was easy enough. So, I set the enchanter to stop scrubbing the configured enchantments every time the block is marked dirty.