This repository has been archived by the owner on Mar 2, 2022. It is now read-only.
Add tor directory parameter to launch_tor #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DonnchaC
reviewed
Feb 11, 2018
bwscanner/attacher.py
Outdated
| @@ -135,7 +135,7 @@ def got_newconsensus(event): | |||
|
|
|||
|
|
|||
| @defer.inlineCallbacks | |||
| def connect_to_tor(launch_tor, circuit_build_timeout, control_port=None, | |||
| def connect_to_tor(launch_tor, circuit_build_timeout, tordir=None, control_port=None, | |||
There was a problem hiding this comment.
Minor nit: we're mostly using underscore separated variable names. It would be more consistent to use tor_dir instead of tordir as the variable name?
DonnchaC
reviewed
Feb 11, 2018
bwscanner/attacher.py
Outdated
| @@ -159,7 +159,7 @@ def connect_to_tor(launch_tor, circuit_build_timeout, control_port=None, | |||
| if launch_tor: | |||
| log.info("Spawning a new Tor instance.") | |||
| # TODO: Pass in data_dir directory so consensus can be cached | |||
There was a problem hiding this comment.
This TODO should be removed in this PR
juga0
force-pushed
the
feature/tordir
branch
from
9a1fff2
to
ccaf654
Compare
juga0
force-pushed
the
feature/tordir
branch
from
ccaf654
to
cb6c636
Compare
|
This PR does not significantly increase the speed of launching Tor when the UseMicroDescriptors option is changed after launching Tor. Tor is throwing away its microdescriptors and redownloading descriptors after each launch. It will be much faster launching Tor after #85 is merged. |
aagbsn
approved these changes
Mar 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe this option should also be provided by cli and should not be an optional argument, as there would be always a default.