fix(meson): force-include Cap'n Proto MSVC interface guard - #398
Open
HaoZeke wants to merge 2 commits into
Open
Conversation
windows.h defines interface and breaks Cap'n Proto templates. Putting /FI in CXXFLAGS makes Meson 1.12's cl.exe sanity check see /FID:/... and report that cl.exe cannot compile programs. add_project_arguments after project() applies /FI only to the real compile.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Benchmark ResultsNote All benchmarks unchanged
8 unchanged benchmark(s)
Details
Raw asv-spyglass output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MSVC
windows.hdefinesinterface, which breaks Cap'n Proto templates. The feedstock was putting/FI msvc_capnp_guard.hinCXXFLAGS; Meson 1.12 feeds those flags into thecl.exesanity compile, a drive-letter include becomes/FID:/..., and setup dies with "Compiler cl.exe cannot compile programs."add_project_arguments('/FI', ...)afterproject()applies the force-include only to the real compile. Same guard as conda-forge/eon-feedstock#30 (0001-win-msvc-capnp-fi-after-project.patch). After the next tarball the feedstock can drop that patch.The remaining win-64 activation work (clear GNU
LDFLAGSsocldoes not see-Wl,.../ D8021;clang_rt/flang_rtLIBPATH) stays on the feedstock. That is compiler-activation, not eOn source.Test plan