FEAT: Implement batch calculations for ase calculators - #409
Open
TobiasDijkhuis wants to merge 2 commits into
Open
FEAT: Implement batch calculations for ase calculators#409TobiasDijkhuis wants to merge 2 commits into
ase calculators#409TobiasDijkhuis wants to merge 2 commits into
Conversation
…ch_calculate' function into the 'ase_calc.py' file.
Author
|
I now realize that main is actually the branch that pull requests are merged into 🥲 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reopening same changes from #407, but rebased on develop branch
Using this change, it would be possible to calculate the forces of both dimer structures, or all NEB images at the same time using an NEB calculator, by putting another function in the same file as
ase_calcand_calculate.I would also like the option to somehow do this using pyeonclient's
potential_from_calc*, but this will do for now 😄I am not the most experienced in C++, so please let me know if I need to change anything.
*Perhaps by checking for a
_batch_calculatemethod that takes the same arguments? This method would then set up the data (e.g. constructase.Atomsfrom the positions, numbers, etc) and call whichever function theCalculatoractually uses to do batch calculations. Maybe food for thought or food for a new issue.Why are the ase potentials from pyeonclient and from within an
ase_calc.pyfile separate anyway? Couldn't you just build an ASE potential from pyeonclient's make_potential_from_ase?