Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mostly cosmetic and very small changes #982

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

mostly cosmetic and very small changes #982

wants to merge 1 commit into from

Conversation

EnthusiastNT
Copy link

    • added a check on isset($table[0]) because that threw an error once
    • utf8mb4 instead of utf8 as default as recommended in the docs
    • mb_substr instead of substr since we use utf8
    • added 3 function aliases for easier understanding (see CHANGED)
    • corrected some spelling and grammar in comments
    • removed a few "@throws Exception" where it wasn't throwing anything
    • added some line breaks for consistency
    • moved orWhere() after where() because... OCD I guess

@EnthusiastNT
mostly cosmetic and very small changes
9b74217 
* - added a check on isset($table[0]) because that threw an error once
* - utf8mb4 instead of utf8 as default as recommended in the docs
* - mb_substr instead of substr since we use utf8
* - added 3 function aliases for easier understanding (see CHANGED)
* - corrected some spelling and grammar in comments
* - removed a few "@throws Exception" where it wasn't throwing anything
* - added some line breaks for consistency
* - moved orWhere() after where() because... OCD I guess
@avbdr
Copy link
Collaborator

avbdr commented Sep 13, 2022

@EnthusiastNT great cleanup thank you.
Can you please remove all the noise comments like CHANGED, remove a changelog on top and as well remove new introdouced helper functions? I dont see much use of this functions since they are acting as 'sugar for the sugar'.
I will be happy to merge this in after. Thank you again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EnthusiastNT @avbdr