Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to 0.4.2; add rpm spec file #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jschauma
Copy link

I've merged the code from http://sourceforge.net/projects/trousers/files/OpenSSL%20TPM%20Engine/ and added a spec file, which you may find useful.

@ThomasHabets
Copy link
Owner

You pulled 0.4.2 from upstream in this pull request? It includes generated files (e.g. "configure") which should not be in version control, and doesn't include the incremental changes I assume upstream has somewhere in their version control.

@jschauma
Copy link
Author

jschauma commented Mar 1, 2014

Thomas Habets notifications@github.com wrote:

You pulled 0.4.2 from upstream in this pull request? It includes
generated files (e.g. "configure") which should not be in version
control, and doesn't include the incremental changes I assume upstream
has somewhere in their version control.

Hmm. That appears to be what is in the tarball from
http://sourceforge.net/projects/trousers/files/OpenSSL%20TPM%20Engine/0.4.2/openssl_tpm_engine-0.4.2.tar.gz/download.

@ThomasHabets
Copy link
Owner

Yes, released tarballs tend to have them, to not require the end user to have autotools installed. Generating them is then done as part of creating the tarball.

And some people do check in the generated files into source control.

In any case changes should be pulled in from source control, not tarballs.

@jschauma
Copy link
Author

jschauma commented Mar 1, 2014

Thomas Habets notifications@github.com wrote:

In any case changes should be pulled in from source control, not
tarballs.

That makes sense to me.

I guess there was just some confusion about this GitHub repository
versus the Sourceforge files.

Having found the sourceforge git files at
http://sourceforge.net/p/trousers/openssl_tpm_engine/ci/master/tree/
feel free to ignore/cancel/discard this pull request.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants