[Blocked on tiledb cloud update] Remove rest.ignore_ssl_validation config option.
#5309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teo-tsirpanis
commented
Sep 13, 2024
| @@ -73,11 +73,6 @@ class S3SSLConfig : public SSLConfig { | |||
| S3SSLConfig(const Config& cfg); | |||
There was a problem hiding this comment.
How about I remove the S3-specific options as well in this PR? They are likewise deprecated and emitting warnings for more than a year.
KiterLuc
changed the title
rest.ignore_ssl_validation config option.rest.ignore_ssl_validation config option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SC-50444
The
rest.ignore_ssl_validationconfig option has been deprecated for more than a year and superseded by the uniformssl.verify(#4087). This PR removes it. Settingrest.ignore_ssl_validationwill no longer have any effect.TYPE: CONFIG
DESC: The deprecated
rest.ignore_ssl_validationconfig option is no longer supported. It is superseded byssl.verifywhich applies to all network requests.