Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix 2D origin #1492

Merged
merged 2 commits into from
Aug 2, 2023
Merged

Conversation

gfardell
Copy link
Member

@gfardell gfardell commented Aug 1, 2023

Describe your changes

Fix to show_geometry for 2D datasets with panel origin set.

Describe any testing you have performed

Please add any demo scripts to CIL-Demos/misc/
Checked origin marker for 2D/3D Cone/Parallel geometries.

Link relevant issues

closes #1491

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@gfardell
Copy link
Member Author

gfardell commented Aug 1, 2023

@lauramurgatroyd I think this addresses an issue you'd previously found when you tried to show the centre slice in a notebook. But I don't recall which one, do you?

@lauramurgatroyd
Copy link
Member

I don't remember, sorry

@gfardell gfardell merged commit 1b20c53 into TomographicImaging:master Aug 2, 2023
3 checks passed
@gfardell gfardell deleted the show_geometry_1491 branch August 2, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

show_geometry on 2D datasets with non-default panel origin bug
2 participants