Allow integer or boolean mask to be passed to Masker #1532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lauramurgatroyd
commented
Nov 1, 2023
gfardell
requested changes
Nov 24, 2023
There was a problem hiding this comment.
I think we may want accept any array and convert it to bool.
mask_boolean = as_array(mask_input, dtype=bool)
This will convert 0s to False and any other value to True, which could catch people out but I think as long as it's documented that:
"masks will be interpreted as boolean with non-zero values set as True"
If the input mask is already boolean then mask_boolean will just be a reference to mask_input
Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
gfardell
reviewed
Dec 21, 2023
lauramurgatroyd
changed the title
|
I have added docstrings on the Returns and a unit test to check that the user's mask is not modified |
gfardell
approved these changes
Jan 10, 2024
paskino
reviewed
Jan 12, 2024
paskino
reviewed
Jan 12, 2024
Co-authored-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com> Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
Co-authored-by: Edoardo Pasca <14138589+paskino@users.noreply.github.com> Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
Signed-off-by: Laura Murgatroyd <60604372+lauramurgatroyd@users.noreply.github.com>
paskino
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Allows Masker to accept an integer array, in which case it is converted to boolean
Describe any testing you have performed
Please add any demo scripts to CIL-Demos/misc/
Added unit test to make sure error is thrown if mask is integer.
Link relevant issues
Closes #1531
Checklist when you are ready to request a review
Contribution Notes
Please read and adhere to the developer guide and local patterns and conventions.