Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the direct method in BlockOperator clearer with a variable name change #1557

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Make the direct method in BlockOperator clearer with a variable name change #1557

merged 5 commits into from
Nov 16, 2023

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Nov 8, 2023 •
edited
Loading

Describe your changes

Just changed the name of a variable in the direct and a variable in the joint to make the code more understandable

Describe any testing you have performed

Please add any demo scripts to CIL-Demos/misc/

Link relevant issues

Closes #1544

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • I confirm that the contribution does not violate any intellectual property rights of third parties

MargaretDuff and others added 2 commits November 8, 2023 17:05
@MargaretDuff
Merge branch 'master' into direct-blockoperator
c903ab8 
Signed-off-by: Margaret Duff <43645617+MargaretDuff@users.noreply.github.com>
@MargaretDuff
Another name change
6c63892
@MargaretDuff MargaretDuff added Merge pending jenkins Once jenkins is happy with can be merged and removed Waiting for review labels Nov 16, 2023
@MargaretDuff MargaretDuff merged commit 0418ed2 into TomographicImaging:master Nov 16, 2023
3 checks passed
@MargaretDuff MargaretDuff deleted the direct-blockoperator branch November 16, 2023 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrobarts hrobarts hrobarts approved these changes

@paskino paskino paskino approved these changes

Assignees
No one assigned
Labels
Merge pending jenkins Once jenkins is happy with can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unlcear direct method in BlockOperator
3 participants
@MargaretDuff @paskino @hrobarts