Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Iterator in BlockDatacontainer #1558

Merged
merged 6 commits into from
Nov 27, 2023
Merged

Iterator in BlockDatacontainer #1558

merged 6 commits into from
Nov 27, 2023

Conversation

MargaretDuff
Copy link
Member

@MargaretDuff MargaretDuff commented Nov 10, 2023 •
edited
Loading

Describe your changes

Bug fix and unit tests to ensure that the BlockDataContainer can be used as an iterator.

Describe any testing you have performed

Please add any demo scripts to CIL-Demos/misc/

Link relevant issues

Closes #1504

Checklist when you are ready to request a review

  • I have performed a self-review of my code
  • I have added docstrings in line with the guidance in the developer guide
  • I have implemented unit tests that cover any new or modified functionality
  • CHANGELOG.md has been updated with any functionality change
  • Request review from all relevant developers
  • Change pull request label to 'Waiting for review'

Contribution Notes

Please read and adhere to the developer guide and local patterns and conventions.

  • The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CIL (the Work) under the terms and conditions of the Apache-2.0 License.
  • I confirm that the contribution does not violate any intellectual property rights of third parties

@MargaretDuff MargaretDuff self-assigned this Nov 22, 2023
@MargaretDuff MargaretDuff added Merge pending jenkins Once jenkins is happy with can be merged and removed Waiting for review labels Nov 24, 2023
@MargaretDuff
Copy link
Member Author

Jenkins is happy:

image

@MargaretDuff MargaretDuff merged commit be57697 into TomographicImaging:master Nov 27, 2023
3 checks passed
@MargaretDuff MargaretDuff deleted the blockdatacontainer-as-iterator branch November 28, 2023 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfardell gfardell gfardell approved these changes

@paskino paskino paskino approved these changes

Assignees

@MargaretDuff MargaretDuff

Labels
Merge pending jenkins Once jenkins is happy with can be merged
Projects
No open projects
Work plan
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BlockDataContainer as iterator
3 participants
@MargaretDuff @paskino @gfardell