fix missing ipps.h by pinning ipp #1581
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
In the last few days tests started failing due to
ipp=2021.10.0
(re)moving theipps.h
header.Possible solutions:
ipp=2021.9.0
(previous version, working)ipps.h
?Describe any testing you have performed
Haven't fully tested, should check upstream (
ipp
) changelog in detail first. According to https://www.intel.com/content/www/us/en/docs/ipp/developer-guide-reference/2021-10/fftinit-r-fftinit-c.html,ipps.h
should still exist in2021.10
. Maybe it's a bug in their latest release?Link relevant issues
Checklist when you are ready to request a review
I have added docstrings in line with the guidance in the developer guideI have implemented unit tests that cover any new or modified functionalityContribution Notes
Please read and adhere to the developer guide and local patterns and conventions.