-
Notifications
You must be signed in to change notification settings - Fork 6
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Create pull_request_template.md (#224)
* Create pull_request_template.md * Update with conventions * Automated autoyapf fixes --------- Co-authored-by: github-actions <github-actions@github.com>
- Loading branch information
1 parent
f40e71d
commit 8c7caca
Showing
1 changed file
with
26 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
## Describe your changes | ||
|
||
|
||
## Describe any testing you have performed | ||
*Consider adding example code to [examples](https://github.com/vais-ral/CILViewer/tree/pr-template/Wrappers/Python/examples)* | ||
|
||
|
||
## Link relevant issues | ||
|
||
|
||
## Checklist when you are ready to request a review | ||
|
||
- [ ] I have performed a self-review of my code | ||
- [ ] I have added docstrings in line with the guidance in the [CIL developer guide](https://tomographicimaging.github.io/CIL/nightly/developer_guide.html) | ||
- [ ] I have implemented unit tests that cover any new or modified functionality | ||
- [ ] CHANGELOG.md has been updated with any functionality change | ||
- [ ] Request review from all relevant developers | ||
- [ ] Change pull request label to 'waiting for review' | ||
|
||
## Contribution Notes | ||
- [ ] The content of this Pull Request (the Contribution) is intentionally submitted for inclusion in CILViewer (the Work) under the terms and conditions of the [Apache-2.0 License](https://spdx.org/licenses/Apache-2.0.html) | ||
- [ ] I confirm that the contribution does not violate any intellectual property rights of third parties | ||
|
||
Qt contributions should follow Qt naming conventions i.e. camelCase method names. | ||
|
||
VTK contributions should follow VTK naming conventions i.e. PascalCase method names. |